Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new setting to "Copy activity" #179

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Added new setting to "Copy activity" #179

merged 3 commits into from
Nov 1, 2023

Conversation

AraPraxis
Copy link
Contributor

The new moodle version allows users to be able to backup activities, without being able to edit the activities.

The sharing cart plugins relies on the edit feature, before it's able to show the sharing cart copy button, or before it's possible to drag and drop.

If a user has access to backup activities but not manage, a new view is shown to copy activities. (Works like "Copy section")
Note that even though the setting is enabled, the "copy activity" will not be shown, if a user can manage activities.

AraPraxis and others added 3 commits September 20, 2023 09:32
@donhinkelman
Copy link
Owner

Thanks, Anders, for all these updates for Sharing Cart into Moodle 4.3. Do you recommend I merge these now? Or test it myself first, which may take time.

@donhinkelman
Copy link
Owner

Also, what does "Some checks were not successful" mean?

@AraPraxis
Copy link
Contributor Author

Hello @donhinkelman
If you wish to test it before merging, I can provide you with the scenario needed to test the new implemented feature, as it relies on the capability of the user roles.

"Some checks were not successful" means that some of the test scenarios were not run correctly. But in this scenario does not mean anything for the plugin.
Someone has created a test suite to check the code on Moodle 4.1 but with PHP version 8.2... PHP version 8.2 was implemented in Moodle 4.2.3 & 4.3+ hence the "error" message - I'll note it and we'll remove it, when updating the plugin again :-)

@donhinkelman donhinkelman merged commit 6d741f5 into donhinkelman:MOODLE_41_STABLE Nov 1, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AraPraxis @donhinkelman @neeesn